On Wednesday 24 February 2016 06:32 AM, Krzysztof Kozlowski wrote: > On 23.02.2016 18:17, pankaj.dubey wrote: >> Hi Krzysztof, >> >> On Tuesday 23 February 2016 05:39 AM, Krzysztof Kozlowski wrote: >>> On 22.02.2016 19:03, Pankaj Dubey wrote: >>>> This includes trivial cleanup in exynos files such as >>>> - remove unused header files inclusion from exynos.c, s5p-dev-mfc.c, >>>> firmware.c, pm.c. >>>> - move inclusion of of.h from common.h to pm.c where it is really >>>> required >>>> >>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> >>>> --- >>>> arch/arm/mach-exynos/common.h | 1 - >>>> arch/arm/mach-exynos/exynos.c | 5 ----- >>>> arch/arm/mach-exynos/firmware.c | 2 -- >>>> arch/arm/mach-exynos/platsmp.c | 1 - >>>> arch/arm/mach-exynos/pm.c | 4 +--- >>>> arch/arm/mach-exynos/s5p-dev-mfc.c | 1 - >>>> 6 files changed, 1 insertion(+), 13 deletions(-) >>>> >>>> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h >>>> index e349a03..5365bf1 100644 >>>> --- a/arch/arm/mach-exynos/common.h >>>> +++ b/arch/arm/mach-exynos/common.h >>>> @@ -12,7 +12,6 @@ >>>> #ifndef __ARCH_ARM_MACH_EXYNOS_COMMON_H >>>> #define __ARCH_ARM_MACH_EXYNOS_COMMON_H >>>> >>>> -#include <linux/of.h> >>>> #include <linux/platform_data/cpuidle-exynos.h> >>>> >>>> #define EXYNOS3250_SOC_ID 0xE3472000 >>>> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c >>>> index 99947ad..54262a1 100644 >>>> --- a/arch/arm/mach-exynos/exynos.c >>>> +++ b/arch/arm/mach-exynos/exynos.c >>>> @@ -11,14 +11,10 @@ >>>> >>>> #include <linux/init.h> >>>> #include <linux/io.h> >>>> -#include <linux/kernel.h> >>>> -#include <linux/serial_s3c.h> >>>> #include <linux/of.h> >>>> #include <linux/of_address.h> >>>> #include <linux/of_fdt.h> >>>> #include <linux/of_platform.h> >>>> -#include <linux/platform_device.h> >>> >>> platform_device is actually used in that file. It looks unused because >>> it is pulled by of_platform, but it makes sense to include it here. >>> >> Thanks for review. >> >> Well I tried to grep for of_platform.h and platform_device.h in >> arch/arm/ and out of 88 files including of_platform.h only 16 files are >> including platform_device.h also. So majority do not include both of >> them even do they need. So majority of files both are not included. So >> If we got with majority it's not required. What's your opinion? > > Actually most of files including of_platform.h and not including > platform_device.h just do not require the second one (I checked like 20 > of them and only one was referring to platform device function... of > course maybe my random selection of 20 files was not random enough :) ). > They do not directly reference platform device stuff. > > In that file the platform_device is used so the header may stay. OK. will resend this again with keeping back platform_device.h in exynos.c file. Thanks, Pankaj Dubey > > Best regards, > Krzysztof > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |