Hi Krzysztof, On Tuesday 23 February 2016 05:33 AM, Krzysztof Kozlowski wrote: > On 22.02.2016 19:03, Pankaj Dubey wrote: >> This patch cleans up map.h by removing unused register offset >> and changing EXYNOS4 to EXYNOS in header comment section. >> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> >> --- >> arch/arm/mach-exynos/include/mach/map.h | 9 +-------- >> 1 file changed, 1 insertion(+), 8 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h >> index 351e839..c48ba4f 100644 >> --- a/arch/arm/mach-exynos/include/mach/map.h >> +++ b/arch/arm/mach-exynos/include/mach/map.h >> @@ -2,7 +2,7 @@ >> * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd. >> * http://www.samsung.com/ >> * >> - * EXYNOS4 - Memory map definitions >> + * EXYNOS - Memory map definitions >> * >> * This program is free software; you can redistribute it and/or modify >> * it under the terms of the GNU General Public License version 2 as >> @@ -14,12 +14,6 @@ >> >> #include <plat/map-base.h> >> >> -/* >> - * EXYNOS4 UART offset is 0x10000 but the older S5P SoCs are 0x400. >> - * So need to define it, and here is to avoid redefinition warning. >> - */ >> -#define S3C_UART_OFFSET (0x10000) >> - >> #include <plat/map-s5p.h> > > This does not look good. The S3C_UART_OFFSET is used in plat/map-s5p.h. > Actually it's just defined there but not getting used anywhere. In fact we can remove it from there also. So I submitted another patch to cleanup such redundant register definitions from plat/map-s5p.h. Only platform using S3C_UART_OFFSET is s3c64xx and its using definition from map-s3c.h. I have compiled all related platform defconfigs and found no issues because of removal of S3C_UART_OFFSET from map-s5p.c and map.h. Thanks, Pankaj Dubey > Best regards, > Krzysztof > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |