Hello Mark. Thank you for your review. Please ignore previous mail that I sent to you. I sent this mail without CC-ing. I resend including CC list. On 2016년 02월 10일 01:10, Mark Brown wrote: > On Wed, Feb 10, 2016 at 12:26:25AM +0900, Youngmin Nam wrote: > >> SPI driver on some SoCs only differ in the fifosize of each >> SPI channel. It is useless to duplicate the s3c64xx_spi_port_config structure >> or create a compatible name for such a change. > > I disagree that it is useless to do this, it means that if we realize > later that there is some other difference between the implementations > then we have the information in the DT to handle this without needing > to update the ABI. > To clarify, let me check that I understood. Do you mean we can fix fifosize of each SPI channel with DT handling if there is difference on this fifosize with driver code? If I understand your words correctly, let me modify commit messages. >> +Optional SoC Specific properties: >> + >> +- samsung,spi-fifosize: The fifo size supported by the SPI channel >> + >> + > > In units of...? FIFO sizes do get quoted in both words and bytes so it > seems good to be clear. > "samsung,spi-fifosize = <64>" means 64 bytes of fifosize. Let me add the units as bytes. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |