On 27.01.2016 12:36, Javier Martinez Canillas wrote: > The max77686 RTC only supports a range of 99 years so instead of using > year 1900 as the base, the year 2000 is used. This means that 1900 to > 1999 are unsupported years. > > The driver was printing a warning for those values but was returning a > error so for consistency, print an error message instead and don't say > that a year 2000 is assumed, since the year is not set. > > Also, it is better to use dev_* log functions instead of pr_* to print > information about the device in the kernel log in a standardized way. > > This also allows to remove the local pr_fmt() defined macro. > > Suggested-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> > > --- > > Changes in v4: > - Use dev_err() instead of dev_warn() and change message. > Suggested by Krzysztof Kozlowski and Andi Shyti. > - Change subject line and commit message of patch #7. > - Removed Laxman Dewangan's Acked-by tag since the patch changed. > > Changes in v3: > - Add Laxman Dewangan's Acked-by tag to patch #7. > > Changes in v2: None > > drivers/rtc/rtc-max77686.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |