> >> if (tm->tm_year < 100) {
> >>- pr_warn("RTC can't handle year %d. Assume it's 2000.\n",
> >>- 1900 + tm->tm_year);
> >>+ dev_warn(info->dev,
> >>+ "RTC can't handle year %d. Assume it's 2000\n",
> >>+ 1900 + tm->tm_year);
> >> return -EINVAL;
> >
> >Because we are returning an error value, why not use dev_err()?
> >
>
> You are absolutely right. Since the driver was using pr_warn(), I used
> dev_warn() but dev_err() would had been correct.
>
> If you don't mind I plan to do it as a follow up patch to avoid having
> to resend the whole series only for this change.
Fine for me!
Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
