On 24.11.2015 08:29, Eduardo Valentin wrote: > On Mon, Nov 23, 2015 at 07:40:41PM +0530, Saurabh Sengar wrote: >> use of_property_read_u8() for u8 variables, >> also changed the return type to void as this function return type >> is nowhere used. >> > > I would be good if you could split both changes into two patches. > > Also, I still do not understand properly the proposal to use u8. > > Why are they u8? > > If they are so, please document them in their DT bindings. Today, the > bindings tell us they are s32 (as there is nothing really specifying the > type). It looks like u8 came from platform data from old times when the driver did not support DT. All of our Exynos mainline boards are converted to DT, so I think legacy platform data can be also changed to match DT. Which means changing from u8 to u32. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |