On 19.11.2015 13:23, Tomasz Figa wrote: > Hi Krzysztof, > > 2015-11-16 10:36 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>: >> The ARMv8 Exynos family SoCs in Linux kernel are currently: >> - Exynos5433 (controlled by ARCH_EXYNOS), >> - Exynos7 (controlled by ARCH_EXYNOS7). >> >> It duplicates Kconfig symbols unnecessarily, so consolidate them into >> one ARCH_EXYNOS. Future SoCs could fall also under the ARCH_EXYNOS >> symbol. >> >> The commit should not bring any visible functional change. > > I think this basically matches the general recommendation for ARM64, > so excluding the single nitpick inline and assuming that, after this > patch, grep ARCH_EXYNOS7 gives no results: > > Reviewed-by: Tomasz Figa <tomasz.figa@xxxxxxxxx> > >> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> >> --- >> arch/arm64/Kconfig.platforms | 11 ++--------- >> arch/arm64/boot/dts/exynos/Makefile | 2 +- >> arch/arm64/configs/defconfig | 2 +- >> 3 files changed, 4 insertions(+), 11 deletions(-) >> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >> index 4043c35962cc..afa19baca94e 100644 >> --- a/arch/arm64/Kconfig.platforms >> +++ b/arch/arm64/Kconfig.platforms >> @@ -13,21 +13,14 @@ config ARCH_BERLIN >> This enables support for Marvell Berlin SoC Family >> >> config ARCH_EXYNOS >> - bool >> - help >> - This enables support for Samsung Exynos SoC family >> - >> -config ARCH_EXYNOS7 >> - bool "ARMv8 based Samsung Exynos7" >> - select ARCH_EXYNOS >> + bool "ARMv8 based Samsung Exynos SoC family" >> select COMMON_CLK_SAMSUNG >> select HAVE_S3C2410_WATCHDOG if WATCHDOG >> select HAVE_S3C_RTC if RTC_CLASS >> select PINCTRL >> select PINCTRL_EXYNOS >> - >> help >> - This enables support for Samsung Exynos7 SoC family >> + This enables support for Samsung Exynos ARMv8 SoC family > > nit: Sounds a little bit strange. Maybe "This enables support for > ARMv8 based Samsung Exynos SoC family"? Sure, sounds better. Thanks for feedback! BR, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |