Re: [PATCH] ARM: dts: exynos5422-odroid*: remove fimd node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



When I was trying to build kernel 4.3.0 (from linux-stable) with
EXYNOS_IOMMU I was getting an kernel oop on boot, which forced me to
restart, so the kernel was not usable. Sadly I didn't make a paste of
it.
Can try to reproduce this error and send it if you like.

Are you not getting this error when building the kernel with it? (I
also own a Odroid U3+.)

Regards :)

2015-11-11 1:43 GMT+01:00 Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>:
> On 10.11.2015 19:24, Marek Szyprowski wrote:
>> FIMD device is not used at all on Exynos5422-based Odroid XU3-lite and
>> XU4. XU3 board teorethically can support FIMD with DisplayPort
>
> s/teorethically/theoretically/
>
>> connector, but due to hw limitation/design it doesn't work in most
>> cases. It is also not even enabled in XU3 dts file.
>>
>> FIMD node was enabled mainly due to limitation of early Exynos DRM
>> driver, which didn't initialize properly when no FIMD device was
>> available. This node can be now safetly removed from XU3-common dtsi and
>
> s/safetly/safely/
>
>> added layer to Odroid XU3 dts, when Display Port driver gets enabled.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 5 -----
>>  1 file changed, 5 deletions(-)
>
> Tested on Odroid XU4 board (HDMI, IOMMU enabled):
>
> Tested-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>
>
> No need for respin, the changelog fixes above can be done during applying.
>
>
> BTW, do you know why we don't have EXYNOS_IOMMU enabled in defconfig?
> Any reasons against?
>
> Best regards,
> Krzysztof
>
>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> index 1af5bdc..9134217 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> @@ -67,11 +67,6 @@
>>                       <19200000>;
>>  };
>>
>> -&fimd {
>> -     status = "okay";
>> -};
>> -
>> -
>>  &hdmi {
>>       status = "okay";
>>       hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux