On 06.11.2015 17:14, Pavel Fedin wrote: > Hello! > >>> +- samsung,srom-timing : array of 6 integers, specifying bank timings in the >>> + following order: Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs. >>> + Each value is specified in cycles and has the following >>> + meaning and valid range: >>> + Tacp : Page mode access cycle at Page mode (0 - 15) >>> + Tcah : Address holding time after CSn (0 - 15) >>> + Tcoh : Chip selection hold on OEn (0 - 15) >>> + Tacc : Access cycle (0 - 32) >> >> All of the manuals have error here. Probably it can be either: 1-32 or >> 0-31. I would bet on 0-31, what do you think? > > Damn, everything starts from 0, so i automatically put '0 - 32'. The actual time, however, varies from 1 to 32, but the value is > from 0 to 31, i. e. <time> - 1 > What shall we do? Just document this, or adjust the code to take number of cycles and subtract 1? To tell the truth, i'm already > sick of these small fixups, and i would prefer just to fix documentation. Whatever you choose. Just make it correct. :) The problem is that Datasheet has errors for these values... Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |