Hi,
On 2015년 10월 30일 16:51, Krzysztof Kozlowski wrote:
> The commit 54e8827d5f0e ("mfd: sec-core: Add support for S2MPU02
> device") added new MFD child devices for S2MPU02: RTC and clock
> provider (the clock provider with new compatible). However support for
> these devices was not added to existing drivers (rtc-s5m, clk-s2mps11).
> New drivers were not submitted neither.
>
> This means that the name of children devices is completely unused. The
> "samsung,s2mpu02-clk" compatible remains undocumented so it is unclear
> what is provided by that compatible.
>
> Clean up this by removing unused child devices and undocumented
> compatible.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>
> ---
>
> I don't think that removing the "samsung,s2mpu02-clk" compatible would
> be considered as ABI break because:
> 1. Kernel did not document it as ABI.
> 2. Kernel did not provide any kind of feature for that compatible. It
> was totally ignored.
> ---
> drivers/mfd/sec-core.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> index 2626fc0b5b8c..989076d6cb83 100644
> --- a/drivers/mfd/sec-core.c
> +++ b/drivers/mfd/sec-core.c
> @@ -103,12 +103,9 @@ static const struct mfd_cell s2mpa01_devs[] = {
> };
>
> static const struct mfd_cell s2mpu02_devs[] = {
> - { .name = "s2mpu02-pmic", },
> - { .name = "s2mpu02-rtc", },
> {
> - .name = "s2mpu02-clk",
> - .of_compatible = "samsung,s2mpu02-clk",
> - }
> + .name = "s2mpu02-pmic",
> + },
> };
>
> #ifdef CONFIG_OF
>
Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
