Hi Pavel,
On Thursday 29 October 2015 12:40 PM, Pavel Fedin wrote:
Hello!
Patch looks ok, but after Alim's patch series [1] to handle poweroff
and reboot via generic syscon based driver gets merged, this will
become redundant entry into PMU driver in the absence of any PMU data
for Exynos5410. Alim has taken care of adding power-off and reboot
device node in exynos5410.dtsi [2].
[1]: http://www.spinics.net/lists/devicetree/msg98858.html
[2]: http://www.spinics.net/lists/devicetree/msg98862.html
I looked at those patches, IMHO they are too large for doing too small thing. What they do is basically describing two registers one-by-one and adding a separate per-register driver. Isn't it too much just for pushing a reset pin?
May be we should just invent some generic "compatible" string, like "samsung,exynos-pmu" (or "Samsung,exynos-pmu-generic", if you want to be more specific), which would do the same as my patch currently does? This would be only several lines of code, achieving the same result.
These patches are not adding any new code, except DT entry. Infact
restart handler will be removed from PMU driver and we will be using
generic syscon based implementation for reboot, which is already present
in Linux kernel. Thus effectively reducing LoC. Only we need to add
device node entries in respective DT files, and this is being done for
all Exynos SoCs including exynos5410.
Thanks,
Pankaj Dubey
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
