On 28.10.2015 16:49, Pavel Fedin wrote: > Hello! > >> The question is - do you prefer us to send a following up patch or to >> fix it by amending the commit? >> >> Here is a fix which can be squashed into these two commits: > > By the way, since we are discussing fixing these commits... > After hardcoded SROMc handling has been removed, Exynos5410-based machines stopped handling it entirely, because the description > has never been added to exynos5410.dtsi (which does not include exynos5.dtsi). Shouldn't the description be added there too? No, it is not needed. The Exynos5410 in current form does not have suspend capability. During boot you should see in dmesg: Failed to find PMU node coming from mach-exynos/suspend.c. In suspend.c there is no compatible for Exynos5410. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html