[adding Bartlomiej to cc] Hello Krzysztof, On 09/08/2015 10:11 AM, Krzysztof Kozlowski wrote: > On 08.09.2015 06:45, Javier Martinez Canillas wrote: >> The Exynos5420 Peach Pit and Exynos5800 Peach Pi boards have a built-in >> Silicon Motion USB UVC WebCam. Enable support for the USB Video Class >> driver and its needed media Kconfig symbols so the camera is supported. >> >> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> >> >> --- >> >> arch/arm/configs/exynos_defconfig | 4 ++++ >> 1 file changed, 4 insertions(+) > > The patch itself looks good but now I wonder whether we are not putting > to much stuff built-in. The exynos_defconfig does not replace the > distribution distro. For a fully working board the distro should prepare > it's own config. > Agreed that exynos_defconfig is not meant to replace a distro config. > I understand that in this case the USB webcams are parts of device (like > on all laptops)... a little bit similar as camera sensors on mobile > phones. Yet on mobile phone usually the camera itself is part of SoC, > only the sensor is external. > > Actually what we need is a kind of policy for exynos_defconfig - what > should be inside as built-in and what as module? > I had the same conversation with Bartlomiej before in [0] when I tried to enable the SBS battery driver as module. I save you a click and quote him: "the current most popular use case for exynos_defconfig (not multi_v7_defconfig) seems to be to build kernel image alone and use it without any modules" Which seems to be true, so my understanding is that exynos_defconfig is a minimal defconfig for Exynos platforms and for easy of test/use, everything should be built-in while multi_v7_defconfig would be more similar to a conf used by distros where most things would be built as a module when possible. Other SoC specific deconfig do it differently, OMAP for example does the opposite and tries to build as much stuff as possible as a module. > Best regards, > Krzysztof > > [0]: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/278757.html Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |