Hello Krzysztof, On 09/04/2015 01:55 AM, Krzysztof Kozlowski wrote: > On 04.09.2015 03:11, Anand Moon wrote: >> Earlier design of the LED for Odroid XU3 was using gpio-leds >> Now It was change to using both pwm-leds and gpio-leds. > > It is still not a reason for this change. gpio-leds were not enabled > before. This could be a valid reason of adding LEDS_PWM to existing > config LEDS_GPIO. But LEDS_GPIO were not enabled... so why the change on > the board from gpio->(gpio+pwm) means that we have to enable LEDS_GPIO? > Agreed, also the commit message doesn't explain why the heartbeat LED trigger is enabled as I mentioned in the previous version. > Actually I gave up on this and I wanted to change the commit message on > myself when applying. But discussion was brought up again so... clearly > we have different understanding of the meaning of "WHY". :) > > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |