On 08/12/2015 09:10 AM, Krzysztof Kozlowski wrote: > On 11.08.2015 20:28, Joonyoung Shim wrote: >> The driver uses clk_prepare_enable()/clk_disable_unprepare() only in >> probe only, elsewhere, use the unified functions for enable/disable of >> clk, e.g. s3c_rtc_enable_clk() / s3c_rtc_disable_clk(), so it's better >> to use them for consistency of code. >> >> Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> >> --- >> drivers/rtc/rtc-s3c.c | 14 +++++++++----- >> 1 file changed, 9 insertions(+), 5 deletions(-) > > First of all - the code is larger (9 insertions, 5 deletion) so I have > doubts if this is better. > > Second - this is not equivalent change. The s3c_rtc_enable_clk/disable > calls grab spin lock which is not necessary in probe. > I made this patch because of patch 4/4, but patch 4/4 should be removed dependency from previous patches, so i will drop this patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |