In my opinion since its something configurable by the board and not SoC specific it should be defined (or re-defined) on the board dts. If one makes a 5422 board booting from A15's that patch will be already invalid and causing the issue that it fixes. 2015-07-14 2:04 GMT-03:00 Kukjin Kim <kgene@xxxxxxxxxx>: > Krzysztof Kozlowski wrote: >> >> On 14.07.2015 09:24, Chanho Park wrote: >> > The odroid-xu3 board which is based on exynos5422 not exynos5800 is >> > booted from cortex-a7 core unlike exynos5800. The odroid-xu3's cpu order >> > is quite strange. cpu0 and cpu5-7 are cortex-a7 cores and cpu1-4 are >> > cortex-a15 cores. To correct this mis-odering, I added exynos5422-cpus.dtsi >> > and reversing cpu orders from exynos5420. Now, cpu0-3 are cortex-a7 and >> > cpu4-7 are cortex-a15. >> > >> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> >> > Signed-off-by: Chanho Park <parkch98@xxxxxxxxx> >> > --- >> > Change from v4: >> > - Resend patch with correct signed-off >> > >> > Changes from v4: >> > - Remove temporal patch in e-mail body >> > >> > Changes from v3: >> > - include this exynos5422-cpus.dtsi in the exynos5422-odroidxu3-common.dtsi >> > >> > Changes from v2: >> > - drop inclusion of exynos5420.dtsi from exynos5422-cpus.dtsi >> > - drop compatibles from exynos5422-cpus.dtsi >> > >> > Changes from v1: >> > - rename exynos5422.dtsi to exynos5422-cpus.dtsi >> > - include the dtsi file top of the exynos5422-odroidxu3.dts >> > >> > Secondary cpu booting problem[1] is not resolved yet. Need more investigations >> > to work booting 8 cores correctly. >> > >> > [1]: http://www.spinics.net/lists/linux-samsung-soc/msg45525.html >> > >> > arch/arm/boot/dts/exynos5422-cpus.dtsi | 81 ++++++++++++++++++++++ >> > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 + >> > 2 files changed, 82 insertions(+) >> > create mode 100644 arch/arm/boot/dts/exynos5422-cpus.dtsi >> >> Thanks, applied to my tree. I'll send it to Kukjin for v4.3 unless he >> picks it also. >> > Well, let me see. I'm thinking we need to sort out the cpu ordering and dtsi > inclusions for exynos5420, 5422 and 5800 related to DT files. > > See, > > 1) exynos5420 DT (cpu0~3: a15, cpu 4~7: a7) > 2) exynos5800 DT is including exynos5420 DT > 3) exynos5422 and exynos5800 based boards are including exynos5800 DT. > > Then making exynos5422-cpus DT for exynos5422 based boards? > (cpu0~3: a7, cpu4~7: a15) > > I think, it could cause confusion when new board based on them are added > because it's not clear and the boot cpu could be selected by bootloader part. > > So how about creating exynos5422-cpus and exynos5420-cpus then including the > cpus DT file in each board accordingly? > > Or more clear way to avoid confusion? > > - Kukjin > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |