On 08.07.2015 14:36, Javier Martinez Canillas wrote: > The dtc compiler combines all the defined nodes that have the same path > so a device node definition can be in one file and later be extended in > another one. > > That's the case of the Exynos5420 pinctrl device nodes that are defined > in the exynos5420.dtsi file and extended in exynos5420-pinctrl.dtsi. > > But since the exynos5420.dtsi file includes the exynos5420-pinctrl.dtsi > before the pinctrl device nodes are actually defined, the definition of > the pinctrl device nodes happens in exynos5420-pinctrl.dtsi and are > extended in exynos5420.dtsi. > > That is the opposite of the original intention so even when there is no > difference in practice, the exynos5420-pinctrl.dtsi include should be > moved at the end of the exynos5420.dtsi file after the pinctrl device > nodes have been already defined. > > This will also allow to later change the exynos5420-pinctrl.dtsi file > to use labels instead of full paths to extend the pinctrl nodes. Since > keeping the include at the top, would cause a dtc build error due the > pinctrl labels not being defined yet. > > Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> > --- > > arch/arm/boot/dts/exynos5420.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |