On 15/06/15 08:46, Javier Martinez Canillas wrote: [...]
Sudeep, so we may need something like $subject after all from Doug's explanations since the combiner chip state is lost during a S2R. I know that it adds more duplicated code (others irqchip drivers do the same) and it may not scale well if a chip has many registers but is the best solution I could came with.
OK
If you have a suggestion for a better alternative, I can give a try and write the patch. But I think $subject could also land to fix this issue since is a very non intrusive change and later can be changed once the irqchip core supports this use case.
Agreed. But I would suggest also to add MASK_ON_SUSPEND and set_irq_wake also and then you can restore iff it's non-zero as irq core will take care of most of the non-wakeup sources. Because I am planning to push MASK_ON_SUSPEND to GIC and it will break this combiner if it assumes the combiner interrupts are always on in GIC. Implement set_irq_wake as enable_irq_wake (comb_irq_to_GIC). Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
