Re: [PATCHv2 3/3] ARM: exynos_defconfig: Enable LEDs for odroidxu3.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13.05.2015 12:52, Anand Moon wrote:
> Enable CONFIG_LEDS_GPIO, CONFIG_LEDS_TRIGGERS, CONFIG_LEDS_TRIGGER_HEARTBEAT.

1. Remove the trailing stop (dot) from commit title.
2. Please go back to default length of wrapping commit messages. This
one exceeds it. Default is 75 characters so git log or git show output
would fit in 80 characters terminal.
3. It would be nice to see here WHY you are enabling these configs (what
is the benefit). One sentence would be enough.

With these changes you can add my tag:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux