Hi Krysztof, Actually the patch is based on https://lkml.org/lkml/2015/4/3/389 I don't know how to measure the energy consumption when compared to cpufreq-exynos. I will update the commit log and resend it with you review. -Anand Moon On 8 May 2015 at 05:44, Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> wrote: > 2015-05-08 2:48 GMT+09:00 Anand Moon <linux.amoon@xxxxxxxxx>: >> Addition of CLK_RECALC_NEW_RATES flag to support Exynos5 cpu clk so that >> correct divider values are re-calculated after both pre/post >> clock notifiers had run for for mout_apll clock and mout_kpll clock. > s/for for/for/ > > Could you precise in commit message the observational effects > *without* this patch? In other words: what is fixed? The divider will > have incorrect values? > >> >> Depend on https://lkml.org/lkml/2015/4/3/388 >> >> Tested on OdroidXU3 Board. > > Thanks for providing this information. However > 1. Patch dependency should not be part of commit message, It simply > won't provide any meaningful information when they are merged. > 2. Similarly testing platform also is not always put in commit message. > > So just put them after separator (triple-dash). > > After fixing the commit message: > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > > Best regards, > Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |