Re: drm/exynos: Add atomic modesetting support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 2015년 05월 07일 06:45, Gustavo Padovan wrote:
> Hi Inki and Joonyoung.
> 
> Any thoughts on this?

You need to resolve one issue that booting is still halted when one more
crtc drivers are enabled, which is a dead lock issue incurred by
register_framebuffer call. For this, I pointed out already at v3.

The last patch may resolve invalid memory access which state->crtc had
NULL while modetest is being performed but it didn't resolve above
booting halt issue.

So as of now, I have merged this patch series for more reviews to
exynos-drm-next-todo yesterday. I will move them to exynos-drm-next if
the issue is resolved.

Thanks,
Inki Dae

> 
> 2015-04-30 Gustavo Padovan <gustavo@xxxxxxxxxxx>:
> 
>> Hi,
>>
>> Here goes the full support for atomic modesetting on exynos. I've
>> split the patches in the various phases of atomic support.
>>
>> v2: fixes comments by Joonyoung
>>         - remove unused var in patch 09
>>         - use ->disable instead of outdated ->dpms in hdmi code
>>         - remove WARN_ON from crtc enable/disable
>>
>> v3: fixes comment by Joonyoung
>>         - move the removal of drm_helper_disable_unused_functions() to
>>         separated patch
>>
>> v4: add patches that remove unnecessary calls to disable_plane()
>>
>> 	Gustavo
>>
>> ---
>> Gustavo Padovan (12):
>>       drm/exynos: atomic phase 1: use drm_plane_helper_update()
>>       drm/exynos: atomic phase 1: use drm_plane_helper_disable()
>>       drm/exynos: atomic phase 1: add .mode_set_nofb() callback
>>       drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy()
>>       drm/exynos: atomic phase 2: keep track of framebuffer pointer
>>       drm/exynos: atomic phase 3: atomic updates of planes
>>       drm/exynos: atomic phase 3: use atomic .set_config helper
>>       drm/exynos: atomic phase 3: convert page flips
>>       drm/exynos: remove exported functions from exynos_drm_plane
>>       drm/exynos: don't disable unused functions at init
>>       drm/exynos: atomic dpms support
>>       drm/exynos: remove unnecessary calls to disable_plane()
>>
>>  drivers/gpu/drm/bridge/ps8622.c             |   6 +-
>>  drivers/gpu/drm/bridge/ptn3460.c            |   6 +-
>>  drivers/gpu/drm/exynos/exynos_dp_core.c     |   6 +-
>>  drivers/gpu/drm/exynos/exynos_drm_crtc.c    | 215 +++++++++----------------------
>>  drivers/gpu/drm/exynos/exynos_drm_dpi.c     |   6 +-
>>  drivers/gpu/drm/exynos/exynos_drm_drv.c     |   2 +
>>  drivers/gpu/drm/exynos/exynos_drm_drv.h     |   4 +-
>>  drivers/gpu/drm/exynos/exynos_drm_dsi.c     |   6 +-
>>  drivers/gpu/drm/exynos/exynos_drm_encoder.c |  35 +----
>>  drivers/gpu/drm/exynos/exynos_drm_fb.c      |  12 +-
>>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c   |   3 -
>>  drivers/gpu/drm/exynos/exynos_drm_plane.c   | 115 +++++++++--------
>>  drivers/gpu/drm/exynos/exynos_drm_plane.h   |  11 --
>>  drivers/gpu/drm/exynos/exynos_drm_vidi.c    |   6 +-
>>  drivers/gpu/drm/exynos/exynos_hdmi.c        |  10 +-
>>  15 files changed, 178 insertions(+), 265 deletions(-)
>>
> 
> 	Gustavo
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux