2015-05-04 3:15 GMT+09:00 Vasily Khoruzhick <anarsoul@xxxxxxxxx>:
> gpiochip_add() allocates memory, however it's not possible anymore
"...to call it..."? Something is missing in the sentence.
> from
> machine map_io() callback thus it failed and prevented machine from booting
> properly.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx>
> ---
> arch/arm/mach-s3c24xx/mach-h1940.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b/arch/arm/mach-s3c24xx/mach-h1940.c
> index 86d9ec7..744aa4f 100644
> --- a/arch/arm/mach-s3c24xx/mach-h1940.c
> +++ b/arch/arm/mach-s3c24xx/mach-h1940.c
> @@ -777,9 +777,14 @@ static void __init h1940_map_io(void)
>
> /* Add latch gpio chip, set latch initial value */
> h1940_latch_control(0, 0);
> - WARN_ON(gpiochip_add(&h1940_latch_gpiochip));
> }
>
> +static __init int h1940_gpiolib_init(void)
> +{
> + return gpiochip_add(&h1940_latch_gpiochip);
> +}
> +core_initcall(h1940_gpiolib_init);
> +
arch_initcall() or init_machine() callback seems more appropriate.
What do you think?
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
