Re: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/08/2015 01:44 AM, Lukasz Majewski wrote:
Hi Anand,

Below changes depend on following patch.
https://patchwork.kernel.org/patch/5944061/

Update the pwm_config with duty then update the pwm_disable
to poweroff the cpu fan.

Tested on OdroidXU3 board.

Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
---
  drivers/hwmon/pwm-fan.c | 10 ++++------
  1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
index 7c83dc4..f25c841 100644
--- a/drivers/hwmon/pwm-fan.c
+++ b/drivers/hwmon/pwm-fan.c
@@ -44,26 +44,24 @@ static int  __set_pwm(struct pwm_fan_ctx *ctx,
unsigned long pwm) int ret = 0;

  	mutex_lock(&ctx->lock);
+
  	if (ctx->pwm_value == pwm)
  		goto exit_set_pwm_err;

-	if (pwm == 0) {
-		pwm_disable(ctx->pwm);
-		goto exit_set_pwm;
-	}
-
  	duty = DIV_ROUND_UP(pwm * (ctx->pwm->period - 1), MAX_PWM);
  	ret = pwm_config(ctx->pwm, duty, ctx->pwm->period);
  	if (ret)
  		goto exit_set_pwm_err;

+	if (pwm == 0)
+		pwm_disable(ctx->pwm);
+
  	if (ctx->pwm_value == 0) {
  		ret = pwm_enable(ctx->pwm);
  		if (ret)
  			goto exit_set_pwm_err;
  	}

-exit_set_pwm:
  	ctx->pwm_value = pwm;
  exit_set_pwm_err:
  	mutex_unlock(&ctx->lock);

Reviewed-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx>

BTW: I've added Guenter to CC.

I don't have a copy of the original patch, so I can't apply it.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux