Hello! Gustavo Padovan wrote: > I would keep calling these two vars x_ratio and y_ratio. I don't see a reason > to change the name here. Right, I'm going to change this. Also I was thinking of basing the patch on your latest cleanup series (the 'drm/exynos: remove struct *_win_data abstraction on planes' one). Then it would just be: static int mixer_setup_scale(const struct exynos_drm_plane *plane, unsigned int *x_ratio, unsigned int *y_ratio) Also that would automatically fix your other comment below [*]. > Use EPERM or ENOTSUPP. Or even true/false. Will do! > You need to fix style here > > if (mixer_setup_scale(win_data->src_width, win_data->src_height, > win_data->crtc_width, win_data->crtc_height, > &x_ratio, &y_ratio)) > return; With [*] this would just be: if (mixer_setup_scale(plane, &x_ratio, &y_ratio)) return; What do you think? > I think your patch is good after these things get fixes and we can go with it > and drop mine. Then I'll just rebase the alpha channel fix patch on top of > this one. Might I suggest to extend the alpha channel patch in this way: https://github.com/tobiasjakobi/linux-odroid/commit/e3aad184eda2cade4d59a874e459a8ff265ed75f With this we get at least some pixelformat validation into the driver. With best wishes, Tobias -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |