On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote: > 2015-03-23 13:34 GMT+01:00 Lee Jones <lee.jones@xxxxxxxxxx>: > > On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: > > > >> From: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > >> > >> This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is > >> equal to S2MPS14's RTC. > >> > >> Cc: Lee Jones <lee.jones@xxxxxxxxxx> > >> Suggested-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > >> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > >> > >> --- > >> > >> Changes since v1: > >> 1. New patch. > >> --- > >> drivers/mfd/sec-core.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Applied, thanks. > > Hi, > > Sorry for the mess but we did this wrong. > The S2MPS13 RTC is slightly different than S2MPS14 and that difference > is important. It is embarrassing... but the difference was written > small-print as a note in datasheet. Really. I found it after carefully > comparing two PDFs. The impact of difference was not detected because > of error in DTS for Exynos5433-based board. > > This patch should be dropped (or reverted) and "s2mps13-rtc" should be > used for S2MPS13 RTC mfd_cell. The RTC driver (rtc/rtxc-s5m) should > have its own support for RTC which I will add in separate patch. > > Lee, once again sorry for the mess. How would you like to proceed? Can > you just drop this commit? Patch removed -- panic averted. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |