Re: [PATCH] ARM: dts: exynos4412-odroid: add 'rtc_src' clock to rtc node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On 03/20/2015 02:38 AM, Chanwoo Choi wrote:
> On 03/20/2015 10:29 AM, Tobias Jakobi wrote:
>> From: Markus Reichl <m.reichl@xxxxxxxxxxxxx>
>> 
>> The Exynos4412 SoC has a s3c6410 RTC where the source clock
>> is now a mandatory property.
>> 
>> This patch fixes probe failure of s3c-rtc on Odroid-X2/U2/U3 boards.
>> 
>> Signed-off-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx>
>> Tested-by: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> index 1ff4c88..0a8e6aa4 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> @@ -9,6 +9,7 @@
>>  
>>  #include <dt-bindings/sound/samsung-i2s.h>
>>  #include <dt-bindings/input/input.h>
>> +#include <dt-bindings/clock/maxim,max77686.h>
>>  #include "exynos4412.dtsi"
>>  
>>  / {
>> @@ -143,6 +144,8 @@
>>  
>>  	rtc@10070000 {
>>  		status = "okay";
>> +		clocks = <&clock CLK_RTC>, <&max77686 MAX77686_CLK_AP>;
>> +		clock-names = "rtc", "rtc_src";
>>  	};
>>  
>>  	g2d@10800000 {
>> 
> 
> Exynos's RTC need the XrtcXTI source clock (32.768kHz). Looks good to me.
> 
> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
>

Yes, I also think this is the correct fix for these boards.

Reviewed-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
 
> Thanks,
> Chanwoo Choi
> 

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux