Hello Andreas, On Mon, Mar 16, 2015 at 11:27 AM, Andreas Färber <afaerber@xxxxxxx> wrote: > Am 16.03.2015 um 08:56 schrieb Javier Martinez Canillas: >> >> I think this should be defined in exynos5410.dtsi instead since is an >> IP block in the SoC and referenced in the .dts using a label to change >> the clock-frequency in the board. > > I hope you understood that this is a literal copy of smdk5410, so I'm > not going to make random changes here. If the Samsung guys want to make > this change for smdk5410, then fine, but otherwise - like for Snow and > Spring - I want to keep the diff -u low between the two. > Yes I did understand that it was a copy but I thought it could be improved anyways. But I don't have a strong opinion either to block this series and always both DTS can be changed as a follow-up. So I'm ok with your decision to keeping the delta to the minimum for now. >> >> Reviewed-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> > > Thanks, first review after posting for the third time... ;) > You are welcome. I usually try to review new Exynos5 DTS but I missed your series before because I was not in the cc list. I only noticed now because you talked about it on irc. > Regards, > Andreas > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |