Hello Marek,
Patch looks good to me. Just a small comment below so feel free to add my
Reviewed by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
On Thu, Mar 5, 2015 at 1:28 PM, Marek Szyprowski
<m.szyprowski@xxxxxxxxxxx> wrote:
> This patch adds nodes for hardware JPEG codec found in Exynos 4210 and
> 4x12 SoCs.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 9 +++++++++
> arch/arm/boot/dts/exynos4x12.dtsi | 4 ++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 77ea547..1bd630a 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -685,6 +685,15 @@
> #include "exynos4412-tmu-sensor-conf.dtsi"
> };
>
> + jpeg-codec@11840000 {
> + compatible = "samsung,exynos4210-jpeg";
> + reg = <0x11840000 0x1000>;
> + interrupts = <0 88 0>;
> + clocks = <&clock CLK_JPEG>;
> + clock-names = "jpeg";
> + samsung,power-domain = <&pd_cam>;
Shouldn't you use the generic "power-domains" property here instead?
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
