Re: [PATCH 1/4] drm/exynos: dsim: fix to control mipi phy register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/02/15 13:17, Inki Dae wrote:
>> Instead I just added syscon support to the PHY layer, it's not perfect
>> > but fixes the issue for both DSI and CSI and  doesn't strip the PHY layer
>> > which could potentially be useful.
>
> Ah, Right. I didn't check your patch set. Your way is a better idea than
> my one. With this, we don't need to change device drivers, MIPI DSI and CSI.
> 
> Then, what is the meaning that it's not perfect?

What I didn't like is that there are at least 3 mutexes on the phy_power_on/
phy_power_off path (PHY core, PHY driver, regmap) and there is another level
of indirection after introducing the regmap. I guess it's nothing serious
though. And BTW the syscon could be converted to use spinlock rather than
a mutex, since in our case behind the PMU syscon is always a memory mapped
region.

-- 
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux