Hi Sylwester, On 02/03/2015 01:44 AM, Chanwoo Choi wrote: > Hi Sylwester, > > On Tue, Feb 3, 2015 at 1:25 AM, Sylwester Nawrocki > <s.nawrocki@xxxxxxxxxxx> wrote: >> Hi Chanwoo, >> >> On 02/02/15 16:51, Chanwoo Choi wrote: >>> On Mon, Feb 2, 2015 at 11:40 PM, Sylwester Nawrocki >>> <s.nawrocki@xxxxxxxxxxx> wrote: >>>>> On 02/02/15 15:08, Chanwoo Choi wrote: >>>>> >>>>>>> OK, I'll add more following information: >>>>>>> I'll send only patch1 with following information. >>>>>>> >>>>>>> + - clocks: list of clock identifiers which are fed as the input to >>>>>>> + the given clock controller. Please refer the next section to >>>>>>> + find the input clocks for a given controller. >>>>>>> + - clock-names: list of names of clocks which are fed as the input >>>>>>> + to the given clock controller. >>>>>>> + >>>>> >>>>> Perhaps: >>>>> >>>>> + - clocks: list of the clock controller input clock identifiers, >>>>> from common clock bindings. Please refer the next section >>>>> to find the input clocks for a given controller. >>>>> >>>>> +- clock-names: list of the clock controller input clock names, >>>>> as described in clock-bindings.txt. >>>>> >>>>> ? >>>>> It's fine to resend just updated first patch from each series. >>> OK, >>> I'll modify the comment of 'clocks' and 'clock-names' and send only first patch. >>> >>> I have a question. Do you prefer to add the list of input clocks for >>> each clock domain as following? >>> Or it is not necessary? >>> >>> + Input clocks for top clock controller: >>> + - oscclk >>> + - sclk_mphy_pll >>> + - sclk_mfc_pll >>> + - sclk_bus_pll >> >> We are supposed to document all required input clocks somehow, I would >> keep the list in such form. The (example) cmu nodes are also a good >> documentation IMHO, they also show clearly which cmu (block) given clock >> is sourced from. > > I agree that the binding document have to contain all required information. > The binding document of exynos5433-clock will contain all input clocks for > each clock domain. Also, I'll modify the description of 'clocks'/'clock-names' > according to your comment and then I'll re-send only updated first > patch for document. I send only updated first patch[1] and will post new patch-set(v3) for remainings 9 patches with input clock information. [1] https://lkml.org/lkml/2015/2/2/761 - [PATCH v6] clk: samsung: exynos5433: Add binding document for Exynos5433 clock domains Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |