+Cc Inki, Hi, On 01/23/2015 09:42 PM, Gustavo Padovan wrote: > From: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx> > > exynos_plane_dpms(DRM_MODE_DPMS_ON) calls the win_enable()'s callback > from the underlying layer. However neither one of these layers implement > win_enable() - FIMD, Mixer and VIDI. Thus the call to exynos_plane_dpms() > is pointless. > No, it needs for pair with DRM_MODE_DPMS_OFF case. Thanks. > Signed-off-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/exynos/exynos_drm_crtc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c > index b1f1b25..d0f4e1b 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c > @@ -65,8 +65,6 @@ static void exynos_drm_crtc_commit(struct drm_crtc *crtc) > > if (exynos_crtc->ops->commit) > exynos_crtc->ops->commit(exynos_crtc); > - > - exynos_plane_dpms(crtc->primary, DRM_MODE_DPMS_ON); > } > > static bool > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |