On 21/01/15 07:26, Chanwoo Choi wrote: > +/* list of all parent clock list */ > +PNAME(mout_bus_pll_user_p) = { "fin_pll", "sclk_bus_pll", }; ... > + > +static struct samsung_mux_clock top_mux_clks[] __initdata = { > + MUX(CLK_MOUT_BUS_PLL_USER, "mout_bus_pll_user", mout_bus_pll_user_p, > + MUX_SEL_TOP1, 0, 1), ... > +}; > + > +static struct samsung_div_clock top_div_clks[] __initdata = { ... > + /* DIV_TOP3 */ > + DIV(CLK_DIV_ACLK_IMEM_SSSX_266, "div_aclk_imem_sssx_266", > + "mout_bus_pll_user", DIV_TOP3, 24, 3), Shouldn't "fin_pll" be renamed to "oscclk" ? In the documentation the root clock (from XXTI input pin) seems to be referred as OSCCLK. And I can't see "fin_pll" clock registered anywhere. Shouldn't there be a "fixed-rate-clock" as a parent of at least CMU_TOP? e.g. xxti: xxti { compatible = "fixed-clock"; #clock-cells = <0>; clock-output-names = "oscclk"; clock-frequency = <24000000>; }; &cmu_top { clocks = <&xxti>; }; -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html