Hi Mark, Thank you for your feedback and sorry for late response. I think, I should remove clock settings in machine driver. If the clock settings are necessary, I will add "assigned-clocks" nodes in trats2 sound DT like odroid board. Best Regards, Inha Song. > On Mon, Jan 05, 2015 at 08:25:16PM +0900, Inha Song wrote: > > > + - clocks : Reference to the codec master clock > > + - clock-names : The clock should be named "mclk" > > This should be done in the CODEC driver, not in the machine driver - the > CODEC always needs the clock, it's not something specific to this > machine. Even if we decide that for Linux the best thing to do is to > manage the clock in the machine driver it should be described in the DT > as being attached to the CODEC. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html