On Thu, Dec 04, 2014 at 04:06:22PM +0100, Arnd Bergmann wrote: > On Thursday 04 December 2014 06:51:49 Guenter Roeck wrote: > > On 12/04/2014 06:44 AM, Geert Uytterhoeven wrote: > > > On Thu, Dec 4, 2014 at 3:26 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > >> On 12/04/2014 05:36 AM, Geert Uytterhoeven wrote: > > >>> On Wed, Aug 20, 2014 at 2:45 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > >>>> Implementing a restart handler in a module don't make sense > > >>>> as there would be no guarantee that the module is loaded when > > >>>> a restart is needed. Unexport arm_pm_restart to ensure that > > >>>> no one gets the idea to do it anyway. > > >>> > > >>> Why not? I was just going to do that, but I got greeted by: > > >> > > >> Because you should register a restart handler instead, like the other > > >> drivers in the same directory now do. > > > > > > That's a different thing. "there would be no guarantee that the module is > > > loaded when a restart is needed" is also valid for restart handlers... > > > > > > > Not really, because you are supposed to unregister the restart handler > > on unload. Sure, you can instead clear arm_pm_reastart and leave the system > > with no means to restart ... > > I agree with Geert that your commit message was confusing, it sounds like > you were referring to drivers that are not yet loaded, while the problem > that you are really address is drivers that have been unloaded later. > Yes, I realize that now. I should probably have added the rationale for the entire series to this commit. I'll try to do better next time. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |