Hi, On 1 December 2014 at 09:59, amit daniel kachhap <amit.daniel@xxxxxxxxxxx> wrote: > On Sun, Nov 30, 2014 at 5:05 AM, Kukjin Kim <kgene@xxxxxxxxxx> wrote: >> Amit Daniel Kachhap wrote: >>> >>> Add PMU settings for exynos7. This is required for future suspend-to-ram, >>> cpuidle and power domain support. >>> >>> Note: In this patch some static declarations lines are over 80 >>> characters per line for easy redability. >>> >>> Reviewed-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> >>> Signed-off-by: Eunseok Choi <es10.choi@xxxxxxxxxxx> >>> Signed-off-by: Abhilash Kesavan <a.kesavan@xxxxxxxxxxx> >>> Signed-off-by: Amit Daniel Kachhap <amit.daniel@xxxxxxxxxxx> >>> --- >>> drivers/soc/samsung/exynos-pmu.c | 427 ++++++++++++++++++++++++++- >>> include/linux/soc/samsung/exynos-regs-pmu.h | 273 +++++++++++++++++ >>> 2 files changed, 699 insertions(+), 1 deletion(-) >>> >> I'm not sure all of the definitions in exynos-regs-pmu are required?...too many, >> and I couldn't check the addresses are correct ;) > Actually i added the PMU power down for almost all the IP's of Exynos7 > as this is full system power down. > I have taken care to add only used macros. >> >> And how about splitting to each SoC specific file in drivers/soc/samsung/ ? >> For example, exynos-pmu.c and exynos7-pmu.c like cpufreq...? Just considering. > Pankaj posted a patch which takes care of this. > It looks like something went wrong, I can't see my post on Samsung and ARM mailing list, but it appeared on LKML. here is link for it.. https://lkml.org/lkml/2014/11/30/175 Thanks, Pankaj Dubey > Regards, > Amit D. >> >> - Kukjin >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html