On Wed, Nov 05, 2014 at 08:43:29AM +0100, Geert Uytterhoeven wrote: > On Wed, Nov 5, 2014 at 2:33 AM, Dmitry Torokhov > <dmitry.torokhov@xxxxxxxxx> wrote: > > On Thu, Oct 30, 2014 at 01:38:30PM -0700, Kevin Hilman wrote: > >> "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx> writes: > >> > >> > On Thursday, October 30, 2014 01:02:49 PM Ulf Hansson wrote: > >> >> Convert the prototype to return and int. This is just an initial step, > >> >> needed to support error handling. > >> >> > >> >> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > >> > >> Acked-by: Kevin Hilman <khilman@xxxxxxxxxx> > >> > >> >> > >> >> This patch is intended as fix for 3.18 rc[n]. Why? > >> >> > >> >> There are other SOC specific patches around that adds genpd support and which > >> >> implements the ->attach_dev() callback. To prevent having an "atomic" patch > >> >> during the next release cycle, let's change the prototype now instead. > >> >> > >> >> Further patches will add the actual error handling in genpd and these can then > >> >> be reviewed and tested thoroughly. > >> > > >> > So we have no users of ->attach_dev at the moment, right? > >> > >> Not in mainline, but there are a couple getting ready to hit -next, so > >> we wanted to fix this before they arrive so that adding the error > >> handling will be easier. > > > > BTW, while we are at it, can we also pass the domain itself to > > attach_dev() and detach_dev()? If anything it helps with debugging (you > > can print domain name from the callbacks). > > You can use dev->pm_domain, which is already set. > > Note that this is no longer the case after Ulf's "[PATCH 3/4] PM / Domains: > Improve error handling while adding/removing devices"! Right, but I'd rather not poke in dev structure directly if I can help it. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |