On 20.10.2014 23:05, Javier Martinez Canillas wrote: > Hello, > > This series add support for Exynos platforms to prepare regulators for > system suspend. The regulator core has a set of helpers functions to be > used when the system is entering and leaving from a suspend state but > currently there is only one user in mainline. > > This user is drivers/mfd/sec-core.c but it calls regulator_suspend_prepare() > from within the driver power-management suspend function. This does not > seems to be correct since the regulator suspend prepare function affects all > regulators in the system and not only the ones managed by this device. > > So patch #1 in this series revert the commit that introduced that change and > patch #2 calls the regulator framework suspend/finish functions from the > Exynos platform power-management code. The first patch should be queued through > the mfd tree and the second through the linux-samsung tree. > > Changes since v2: > - Check for regulator_suspend_finish() return value for an error. > Suggested by Doug Anderson. > > Changes since v1: > - Remove the call to regulator_suspend_prepare() from drivers/mfd/sec-core.c > as suggested by Doug Anderson. > - Call regulator_suspend_prepare() before s3c_pm_check_prepare() as suggested > by Doug Anderson. > - Added Lee Jones to cc list since there is a change for the mfd framework. > > Javier Martinez Canillas (2): > Revert "mfd: sec-core: Prepare regulators for suspend state to reduce > power-consumption" > ARM: EXYNOS: Call regulator core suspend prepare and finish functions > > arch/arm/mach-exynos/suspend.c | 23 +++++++++++++++++++++++ > drivers/mfd/Kconfig | 1 - > drivers/mfd/sec-core.c | 10 ---------- > 3 files changed, 23 insertions(+), 11 deletions(-) Patchset tested on Trats2 board (Exynos4412 with max77686 PMIC, modified DTS to disable buck[134] during suspend to RAM). Tested-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html