Javier, On Mon, Oct 20, 2014 at 2:05 PM, Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> wrote: > This reverts commit b7cde7078d2344073c310aa65fc2b0a845d2cb5b > ("mfd: sec-core: Prepare regulators for suspend state to reduce power-consumption") > > Commit b7cde7078d23 called regulator_suspend_prepare() to prepare the > regulators for a suspend state. But it did from the device pm suspend > handler while the regulator suspend prepare function iterates over all > regulators and not only the one managed by this device so it doesn't > seems to be correct to call it from within a device driver. > > It is better to call the regulator suspend prepare/finish functions > from platform code instead so this patch reverts the mentioned commit. > > Suggested-by: Doug Anderson <dianders@xxxxxxxxxxxx> > Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html