On Wed, Oct 15, 2014 at 06:20:32PM +0200, Javier Martinez Canillas wrote:
> +#define MAX77802_MODE(pval) ((pval == MAX77802_OPMODE_NORMAL) ? \
> + REGULATOR_MODE_NORMAL : REGULATOR_MODE_STANDBY)
> +
Make this a static inline function if there's any need for it, this is
both more legible and more helpful for the compiler.
> + switch (mode) {
> + case REGULATOR_MODE_IDLE:
> + case REGULATOR_MODE_STANDBY:
> + val = MAX77802_OPMODE_LP; /* ON in Low Power Mode */
> + break;
You should never have multiple modes mapping onto a singel value - if
the user sets a mode they should find that the device has that mode.
Attachment:
signature.asc
Description: Digital signature
