On Fri, Oct 03, 2014 at 10:24:09AM +0200, Andrzej Hajda wrote: > The main intent of this patchset is to allow use of suspend/resume drm driver > callbacks in KMS drivers, as these callbacks seems to me the best place > to implement suspend/resume functionality in drm driver. > Implementing this functionality in master component driver PM ops is problematic > as those callbacks can be called asynchronously regardless of state/existence of > drm device, thus it would require additional synchronization mechanism. > > Callbacks re-enabling requires small changes in i915 and exynos driver. > The patchset contains also fix of exynos resume callback. Nack. Like completely and totally. The drm core has really no business doing hardware stuff, which includes runtime pm, system suspend and all that nonsense. It' an interface between userspace and drivers, with a big library to back it all up. Everything else just repeats the old midlayer mistake. If you driver needs this, do it there. Also, the component framework is probably the solution you're looking for. And if there are synchronization issues with that then we need to fix those instead of reinventing yet another half-assed broken wheel. Aside: With David Herrmann's latest patches to de-midlayer the drm init/teardown sequence the driver is in full control of when the drm data structures get allocate, initialized and registered. If you convert to that plus the component framework I'm pretty sure your problem is solved. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |