Hi Tomasz,
On Wednesday, October 01, 2014 4:07 PM, Tomasz Figa wrote,
> To: Pankaj Dubey; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-
> soc@xxxxxxxxxxxxxxx
> Cc: kgene.kim@xxxxxxxxxxx; linux@xxxxxxxxxxxxxxxx; thomas.ab@xxxxxxxxxxx;
> vikas.sajjan@xxxxxxxxxxx; linux@xxxxxxxxxxxx; naushad@xxxxxxxxxxx
> Subject: Re: [PATCH 2/2] ARM: EXYNOS: PMU: move restart code into pmu
> driver
>
> Hi Pankaj,
>
> Please see my comments inline.
>
> On 01.10.2014 07:49, Pankaj Dubey wrote:
> > Let's register reboot_notifier from PMU driver for reboot
> > functionality. So that we can remove restart hooks from machine
> > specific file, and thus moving ahead when PMU moved to driver folder,
> > this functionality can be reused for ARM64 based Exynos SoC's.
>
> [snip]
>
> > +static int pmu_reboot_notify_handler(struct notifier_block *this,
> > + unsigned long code, void *unused)
> > +{
> > + if (code == SYS_RESTART) {
> > + u32 val = 0x1;
> > +
> > + pmu_raw_writel(val, EXYNOS_SWRESET);
>
> As already mentioned for patch 1, no need for the variable, because this
is just a
> constant 1.
>
Thanks for review.
Addressed all your review comments for this patch series in v2.
Thanks,
Pankaj Dubey
> Best regards,
> Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
