Re: [PATCH 2/2] arch: arm: samsung: Clean-up usage of CONFIG_SERIAL_SAMSUNG_UARTS symbol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 30 September 2014 18:10:14 Tomasz Figa wrote:
> >> @@ -110,7 +110,7 @@ void __init s3c24xx_init_uartdevs(char *name,
> >>                                   struct s3c24xx_uart_resources *res,
> >>                                   struct s3c2410_uartcfg *cfg, int no)
> >>  {
> >> -#ifdef CONFIG_SERIAL_SAMSUNG_UARTS
> >> +#ifdef CONFIG_SERIAL_SAMSUNG
> >>         struct platform_device *platdev;
> >>         struct s3c2410_uartcfg *cfgptr = uart_cfgs;
> >>         struct s3c24xx_uart_resources *resp;
> > 
> > Since you hardcode the number here now, you can actually drop this #ifdef.
> 
> I believe what Abhilash did is correct, because this code is not needed
> when there is no serial support enabled.
> 

I only added the #ifdef here because it was broken when
CONFIG_SERIAL_SAMSUNG_UARTS was undefined.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux