On 23.09.2014 14:53, Alim Akhtar wrote: > Hi Marek, > > On Mon, Sep 22, 2014 at 6:44 PM, Marek Szyprowski > <m.szyprowski@xxxxxxxxxxx> wrote: >> Hello, >> >> This patchset adds support for early console defined in device tree. As >> an example, DTS files for all Exynos4 based machines are updated with >> the correct value for common chosen/sdtout property. >> >> To get it fully functional additional improvements (support for >> early_ioremap) are needed in early console code. >> > Is these really tested? > So that mean we need to wait till __ioremap__ support available for ARM. This was originally tested by creating a fixed mapping for all UART ports on respective platforms in .map_io() callback of machine descriptor. This might be the way to support this on 32-bit ARM platforms until early ioremap is available. However if no mapping is available, the earlycon will simply not register and won't break anything, so it should be safe to keep. > How to take this forward then? Here is a platform (exynos7) which > needs earlycon support for debugging some of the early core things and > ARM64 has ioremap support as well. There is no reason why we should > hold earlycon support for exyons7. > I see two solution here: > 1> How about re-spin patch-1 which will just add ealrycon support for > __exynos4210__ serial type only? And rest of the types can be added as > incremental patches, as and when ioremap for ARM available. > Atleast this approch will solve exynos7 problem of not having earlycon support. > And This patch can be tested on exynos7 (I can do that). I don't really think there is a need to remove support for other variants. As I mentioned, they can be supported without early_ioremap() by static IO mapping. > 2> Take my patch which is working and tested for exynos7 and can be > easily extended and generalized when ioremap for ARM is available. > > My preference would be the the first one. > Let me know your thoughts please. > In case you are ok with 1st approach, can you please re-spin patch1 > with needed changes? I'd say this patch could be merged as is. For 32-bit platforms additional patches might be posted separately to add early static mapping or just wait until early ioremap becomes availabl.e Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |