On Fri, Sep 19, 2014 at 6:24 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > On 18/09/14 08:50, Ajay kumar wrote: > >>>> Why do we need a complex graph when it can be handled using a simple phandle? >>> >>> Maybe in your case you can handle it with simple phandle. Can you >>> guarantee that it's enough for everyone, on all platforms? >> Yes, as of now exynos5420-peach-pit and exynos5250-spring boards use >> this. In case of both, the phandle to bridge node is passed to the >> exynos_dp node. >> >>> The point of the ports/endpoint graph is to also support more >>> complicated scenarios. If you now create ps8622 bindings that do not >>> support those graphs, the no one else using ps8622 can use >>> ports/endpoint graphs either. >>> >>> Btw, is there an example how the bridge with these bindings is used in a >>> board's .dts file? I couldn't find any example with a quick search. So >>> it's unclear to me what the "simple phandle" actually is. >> Please refer to the following link: >> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/tree/arch/arm/boot/dts/exynos5420-peach-pit.dts?id=samsung-dt#n129 >> Let me know if you still think we would need to describe it as a complex graph! > > Yes, I think so. I'm not the DRM maintainer, though. > > I think we have two options: > > 1) Describe the video component connections with the ports/endpoints > properly for all new display device bindings, and know that it's > (hopefully) future proof and covers even the more complex boards that > use the devices. > > or > > 2) Use some simple methods to describe the links, like single phandle as > you do, knowing that we can't support more complex boards in the future. I am not really able to understand, what's stopping us from using this bridge on a board with "complex" display connections. To use ps8622 driver, one needs to "attach" it to the DRM framework. For this, the DRM driver would need the DT node for ps8622 bridge. For which I use a phandle. If some XYZ platform wishes to pick the DT node via a different method, they are always welcome to do it. Just because I am not specifying a video port/endpoint in the DT binding example, would it mean that platform cannot make use of ports in future? If that is the case, I can add something like this: http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/panel/samsung,ld9040.txt#L61 Regards, Ajay kumar > I see some exynos boards already using the ports/endpoints, like > arch/arm/boot/dts/exynos4412-trats2.dts. Why not use it for all new > display devices? > > Tomi > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |