On Thu, Sep 18, 2014 at 08:59:32AM +0530, Pankaj Dubey wrote: > +CC: Dong Aisheng > > Hi Arnd, > > On Wednesday, September 17, 2014, Arnd Bergmann wrote, > > > V2 of this patchset and related discussion can be found here [1]. > > > > > > Changes since v2: > > > - Added back platform device support from syscon, with one change that > > > syscon will not be probed for DT based platform. > > > - Added back syscon_regmap_lookup_by_pdevname API so that non-DT base > > > users of syscon will not be broken. > > > - Removed unwanted change in syscon.h. > > > - Modified Signed-off-by list, added Suggested-by of Tomasz Figa and > > > Arnd Bergmann. > > > - Added Tested-by of Vivek Gautam for testing on Exynos platform. > > > > Looks fine. Provided you can figure out the problem that Dong Aisheng > reported, > > please add my > > > > Acked-by: Arnd Bergmann <arnd@xxxxxxxx> > > > > Thanks. > After he reported I have again done code walk-through of regmap_init_mmio > and > could not see any such fatal error. At the same time I have replied to Dong > Aisheng, > asking for more details and waiting for his reply. > I just replied and gave the log. Regards Dong Aisheng > > > -} > > > +static struct syscon *of_syscon_register(struct device_node *np); > > > > > > > One minor comment: please avoid doing forward declarations of local > functions. It > > took me a while to understand what is going on because I expect all > functions to be > > ordered such that they only get called by functions below, and don't need > this. > > > > Just move of_syscon_register() here directly. > > > > OK, I will remove forward declaration of "of_syscon_register" and respin > patch once again. > > > Arnd > > Thanks, > Pankaj Dubey > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |