Hi Ulf, On Wed, Sep 3, 2014 at 12:52 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > --- a/drivers/base/power/domain_governor.c > +++ b/drivers/base/power/domain_governor.c > @@ -229,10 +229,7 @@ static bool always_on_power_down_ok(struct dev_pm_domain *domain) > > #else /* !CONFIG_PM_RUNTIME */ > > -bool default_stop_ok(struct device *dev) > -{ > - return false; > -} > +static inline bool default_stop_ok(struct device *dev) { return false; } The "inline" doesn't make much sense here. This function is only referenced from places that need its address: struct dev_power_governor simple_qos_governor = { .stop_ok = default_stop_ok, .power_down_ok = default_power_down_ok, }; and struct dev_power_governor pm_domain_always_on_gov = { .power_down_ok = always_on_power_down_ok, .stop_ok = default_stop_ok, }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html