Re: [PATCH 6/6] ARM: dts: Add tps65090 FETs constraints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/12/2014 10:44 AM, Javier Martinez Canillas wrote:
The tps65090 PMU data manual [0] has a table that list the
"Recommended operating conditions" for each regulator. Add
the information about the FET constraints to its dtsi file.

[0]: http://www.ti.com/lit/ds/symlink/tps65090.pdf

I'm worried that this file represents the limits of the PMIC itself, whereas the DT should be representing the limits of the circuits that the various PMIC regulators are attached to on the board.

For example:

diff --git a/arch/arm/boot/dts/tps65090.dtsi b/arch/arm/boot/dts/tps65090.dtsi

  		tps65090_fet3: fet3 {
+			regulator-min-microvolt = <3000000>;
+			regulator-max-microvolt = <5500000>;
  		};

I guess that on some boards, this output rail might be attached to devices that must run at 3.3V exactly, and on other boards it might be attached to devices that must run at 5V exactly. The DT for those two boards should each have regulator-{min,max}-microvolt set to the same value, which describes the board requirements.

It feels dangerous/misleading to define the PMIC range by default. It might lead people to think that since the property already has a defined value, they don't need to think about what the correct value for their board is, and hence not change the value in their board file.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux