Hello Linus, On 08/11/2014 10:32 AM, Linus Walleij wrote: > I guess this discussion is about drivers/pinctrl/samsung/pinctrl-exynos.c? > > Or else I'm not really following this... $SUBJECT is a bit confusing. > Yes, the thing is that at the beginning I (wrongly) thought that the IRQ trigger type flags defined in the DTS were discarded if someone called request_threaded_irq() with a flags != 0. And since the atmel touchpad driver was pass pdata->irqflags | IRQF_ONESHOT I posted this patch to get the trigger type parsed from DT and pass it to request_threaded_irq(). But after digging further I found that the issue was in the pinctrl-exynos driver and Tomasz explained to me that the real cause was that the pin was being configured from GPIO IRQ to GPIO input (which on other platforms is just the same mode but on Exynos are two different modes). At the end passing the trigger type to request_threaded_irq() just had the side effect to call the exynos .irq_set_type function handler that reconfigured the pin as GPIO-IRQ and that is why it made it to work. So I posted a patch from Tomasz that fixes the real cause [0]. I'm so sorry for the confusion. > Yours, > Linus Walleij > Best regards, Javier [0]: https://lkml.org/lkml/2014/8/8/962 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |