On czw, 2014-08-07 at 18:48 +0200, Bartlomiej Zolnierkiewicz wrote: > [ added missing linux-samsung-soc ML, sorry for the noise ] > > On Thursday, August 07, 2014 06:44:18 PM Bartlomiej Zolnierkiewicz wrote: > > sec_irq_init() can fail if it encounters unknown device type or > > on regmap_add_irq_chip() error. Add missing sec_irq_init() return > > value checking to sec_pmic_probe(). > > > > Tested on Insignal's Exynos4412 based Origen board. > > > > Cc: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > > Cc: Sangbeom Kim <sbkim73@xxxxxxxxxxx> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > > Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > --- > > patch is against next-20140804 branch of linux-next kernel > > > > drivers/mfd/sec-core.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) Looks and works good (tested on board with S2MPS14). Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Tested-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Best regards, Krzysztof > > > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > > index dba7e2b..f498867 100644 > > --- a/drivers/mfd/sec-core.c > > +++ b/drivers/mfd/sec-core.c > > @@ -353,7 +353,9 @@ static int sec_pmic_probe(struct i2c_client *i2c, > > if (pdata && pdata->cfg_pmic_irq) > > pdata->cfg_pmic_irq(); > > > > - sec_irq_init(sec_pmic); > > + ret = sec_irq_init(sec_pmic); > > + if (ret) > > + return ret; > > > > pm_runtime_set_active(sec_pmic->dev); -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |