Hi Thomas,
Am 29.07.2014 14:35, schrieb Thomas Abraham:
> On Tue, Jul 29, 2014 at 5:38 PM, Andreas Färber <afaerber@xxxxxxx> wrote:
>> Am 29.07.2014 07:28, schrieb Thomas Abraham:
>>> diff --git a/arch/arm/boot/dts/exynos5250-cros-common.dtsi b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
>>> index 89ac90f..34bb31c 100644
>>> --- a/arch/arm/boot/dts/exynos5250-cros-common.dtsi
>>> +++ b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
>>> @@ -19,6 +19,12 @@
>>> chosen {
>>> };
>>>
>>> + cpus {
>>> + cpu@0 {
>>> + cpu0-supply = <&buck2_reg>;
>>> + };
>>> + };
>>> +
>>> pinctrl@11400000 {
>>> /*
>>> * Disabled pullups since external part has its own pullups and
>>
>> I've been instructed to dismantle this .dtsi file, so please place this
>> into exynos5250-snow.dts. It's probably wrong here anyway, since Spring
>> doesn't use the max77686 but an s5m6787 PMIC.
>
> Ok, I will move this to exynos5250-snow.dts.
>
>>
>> How do I find out which -supply to specify here for Spring?
>
> This information can be found in the Spring board schematic.
Are those available publicly somewhere? I guess not...
>> Also, wouldn't it make sense to assign a cpu0 label in exynos????.dtsi
>> to override it via &cpu0 { ... };?
>
> Sorry, I did not understand the question.
Instead of adding
cpus { cpu@0 { ... }; };
to the board's / node, I am suggesting you do in the SoC's .dtsi:
- cpu@0 {
+ cpu0: cpu@0 {
and then in the board's file after / { ... }; add the following:
&cpu0 {
cpu0-supply = <&buck2_reg>;
};
This is the new preferred way to override or extend inherited nodes, I
am told. (&cpu0 should be inserted in alphabetical order then.)
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
